[
https://issues.apache.org/jira/browse/FLINK-4192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389345#comment-15389345
]
ASF GitHub Bot commented on FLINK-4192:
---------------------------------------
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2226
I tried to see if we can move the entire set of metrics classes to the
independent `flink-metrics-core` module. Here is how that would look like:
https://github.com/StephanEwen/incubator-flink/tree/move_metrics
- The runtime-specific metric groups are in `runtime.metrics` in
`flink-runtime`. It makes sense dependency wise, because that way, we can
actually use the proper types (like `ExecutionID`)
- ScopeFormats are also bound to the component metric groups, not the
registry as a whole
- Everything else is in the `flink-metrics-core` module.
Remaining issues:
- The JMX reporter currently uses the `NetUtils`, which are now not
available any more.
- The `MetricRegistry` relied on `Configuration` before. It can now only
rely on `MetricConfig`, which we have to efficiently extract from the
configuration.
> Move Metrics API to separate module
> -----------------------------------
>
> Key: FLINK-4192
> URL: https://issues.apache.org/jira/browse/FLINK-4192
> Project: Flink
> Issue Type: Improvement
> Components: Metrics
> Affects Versions: 1.1.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Fix For: 1.1.0
>
>
> All metrics code currently resides in flink-core. If a user implements a
> reporter and wants a fat jar it will now have to include the entire
> flink-core module.
> Instead, we could move several interfaces into a separate module.
> These interfaces to move include:
> * Counter, Gauge, Histogram(Statistics)
> * MetricGroup
> * MetricReporter, Scheduled, AbstractReporter
> In addition a new MetricRegistry interface will be required as well as a
> replacement for the Configuration.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
