tillrohrmann commented on a change in pull request #18286: URL: https://github.com/apache/flink/pull/18286#discussion_r783155440
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/PendingRequest.java ########## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.jobmaster.slotpool; + +import org.apache.flink.runtime.clusterframework.types.AllocationID; +import org.apache.flink.runtime.clusterframework.types.ResourceProfile; +import org.apache.flink.runtime.jobmaster.SlotRequestId; + +import java.util.Collection; +import java.util.HashSet; +import java.util.Set; +import java.util.concurrent.CompletableFuture; + +final class PendingRequest { + + private final SlotRequestId slotRequestId; + + private final ResourceProfile resourceProfile; + + private final HashSet<AllocationID> preferredAllocations; + + private final CompletableFuture<PhysicalSlot> slotFuture; + + private final boolean isBatchRequest; + + private long unfulfillableSince; + + private PendingRequest( + SlotRequestId slotRequestId, + ResourceProfile resourceProfile, + Collection<AllocationID> preferredAllocations, + boolean isBatchRequest) { + this.slotRequestId = slotRequestId; + this.resourceProfile = resourceProfile; + this.preferredAllocations = new HashSet<>(preferredAllocations); + this.isBatchRequest = isBatchRequest; + this.slotFuture = new CompletableFuture<>(); + this.unfulfillableSince = Long.MAX_VALUE; + } + + static PendingRequest createBatchRequest( + SlotRequestId slotRequestId, + ResourceProfile resourceProfile, + Collection<AllocationID> preferredAllocations) { + return new PendingRequest(slotRequestId, resourceProfile, preferredAllocations, true); + } + + static PendingRequest createNormalRequest( + SlotRequestId slotRequestId, + ResourceProfile resourceProfile, + Collection<AllocationID> preferredAllocations) { + return new PendingRequest(slotRequestId, resourceProfile, preferredAllocations, false); + } + + SlotRequestId getSlotRequestId() { + return slotRequestId; + } + + ResourceProfile getResourceProfile() { + return resourceProfile; + } + + public Set<AllocationID> getPreferredAllocations() { + return preferredAllocations; + } + + CompletableFuture<PhysicalSlot> getSlotFuture() { + return slotFuture; + } + + void failRequest(Exception cause) { + slotFuture.completeExceptionally(cause); + } + + public boolean isBatchRequest() { + return isBatchRequest; + } + + public void markFulfillable() { Review comment: I think this makes sense. I will change it. ########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/PendingRequest.java ########## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.jobmaster.slotpool; + +import org.apache.flink.runtime.clusterframework.types.AllocationID; +import org.apache.flink.runtime.clusterframework.types.ResourceProfile; +import org.apache.flink.runtime.jobmaster.SlotRequestId; + +import java.util.Collection; +import java.util.HashSet; +import java.util.Set; +import java.util.concurrent.CompletableFuture; + +final class PendingRequest { + + private final SlotRequestId slotRequestId; + + private final ResourceProfile resourceProfile; + + private final HashSet<AllocationID> preferredAllocations; + + private final CompletableFuture<PhysicalSlot> slotFuture; + + private final boolean isBatchRequest; + + private long unfulfillableSince; + + private PendingRequest( + SlotRequestId slotRequestId, + ResourceProfile resourceProfile, + Collection<AllocationID> preferredAllocations, + boolean isBatchRequest) { + this.slotRequestId = slotRequestId; + this.resourceProfile = resourceProfile; + this.preferredAllocations = new HashSet<>(preferredAllocations); + this.isBatchRequest = isBatchRequest; + this.slotFuture = new CompletableFuture<>(); + this.unfulfillableSince = Long.MAX_VALUE; + } + + static PendingRequest createBatchRequest( + SlotRequestId slotRequestId, + ResourceProfile resourceProfile, + Collection<AllocationID> preferredAllocations) { + return new PendingRequest(slotRequestId, resourceProfile, preferredAllocations, true); + } + + static PendingRequest createNormalRequest( + SlotRequestId slotRequestId, + ResourceProfile resourceProfile, + Collection<AllocationID> preferredAllocations) { + return new PendingRequest(slotRequestId, resourceProfile, preferredAllocations, false); + } + + SlotRequestId getSlotRequestId() { + return slotRequestId; + } + + ResourceProfile getResourceProfile() { + return resourceProfile; + } + + public Set<AllocationID> getPreferredAllocations() { + return preferredAllocations; + } + + CompletableFuture<PhysicalSlot> getSlotFuture() { + return slotFuture; + } + + void failRequest(Exception cause) { + slotFuture.completeExceptionally(cause); + } + + public boolean isBatchRequest() { + return isBatchRequest; + } + + public void markFulfillable() { Review comment: I think this makes sense. I will change it to package private. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
