tillrohrmann commented on a change in pull request #18286: URL: https://github.com/apache/flink/pull/18286#discussion_r782904887
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SimpleRequestSlotMatchingStrategy.java ########## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.jobmaster.slotpool; + +import org.apache.flink.runtime.jobmaster.SlotRequestId; + +import java.util.ArrayList; +import java.util.Collection; +import java.util.Iterator; +import java.util.LinkedHashMap; + +/** + * Simple implementation of the {@link RequestSlotMatchingStrategy} that matches the pending + * requests in order as long as the resource profile can be fulfilled. + */ +public enum SimpleRequestSlotMatchingStrategy implements RequestSlotMatchingStrategy { + INSTANCE; + + @Override + public Collection<RequestSlotMatching> matchRequestsAndSlots( + Collection<? extends PhysicalSlot> slots, Collection<PendingRequest> pendingRequests) { + final Collection<RequestSlotMatching> resultingMatchings = new ArrayList<>(); + + // if pendingRequests has a special order, then let's preserve it + final LinkedHashMap<SlotRequestId, PendingRequest> pendingRequestsIndex = Review comment: We don't. I think you are right and we should use a `LinkedList` here. Will change it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
