tillrohrmann commented on a change in pull request #18286:
URL: https://github.com/apache/flink/pull/18286#discussion_r783181844
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/slotpool/DeclarativeSlotPoolBridgeTest.java
##########
@@ -55,13 +59,26 @@
import static org.junit.Assert.fail;
/** Tests for the {@link DeclarativeSlotPoolBridge}. */
+@RunWith(Parameterized.class)
public class DeclarativeSlotPoolBridgeTest extends TestLogger {
private static final Time rpcTimeout = Time.seconds(20);
private static final JobID jobId = new JobID();
private static final JobMasterId jobMasterId = JobMasterId.generate();
private final ComponentMainThreadExecutor mainThreadExecutor =
ComponentMainThreadExecutorServiceAdapter.forMainThread();
+ private final RequestSlotMatchingStrategy requestSlotMatchingStrategy;
+
+ @Parameterized.Parameters(name = "RequestSlotMatchingStrategy: {0}")
+ public static Collection<RequestSlotMatchingStrategy> data() throws
IOException {
+ return Arrays.asList(
+ SimpleRequestSlotMatchingStrategy.INSTANCE,
+ PreferredAllocationRequestSlotMatchingStrategy.INSTANCE);
+ }
+
+ public DeclarativeSlotPoolBridgeTest(RequestSlotMatchingStrategy
requestSlotMatchingStrategy) {
+ this.requestSlotMatchingStrategy = requestSlotMatchingStrategy;
Review comment:
I am not sure whether it adds all that much additional benefit since we
already have `PreferredAllocationRequestSlotMatchingStrategyTest` that tests
the strategy. So what we are effectively testing is that the strategy is
called. But maybe it is not too hard to add a test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
