JingGe commented on pull request #18333: URL: https://github.com/apache/flink/pull/18333#issuecomment-1012186184
> > I don't think we have any promise to support IntelliJ with any price. > > Maybe not, but de facto this is what we recommend and what people use. If we make tests difficult to execute or, worse, produce incorrect results when executed, it will lead to a lead of friction and questions. > > > What if all the violations found by IntelliJ have been resolved? > > That doesn't help, because if the CI doesn't catch such cases, any PR might introduce a new "IntelliJ-only" violation and the next time someone needs to execute the architectural tests locally, they see differences to the maven execution. Fire enough. I just have big concern that, if perfection is required, we might need a big refactoring on the codebase, since the whole test modules in Flink are not in a good shape, as I mentioned previously. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
