JingGe edited a comment on pull request #18333: URL: https://github.com/apache/flink/pull/18333#issuecomment-1012120080
@Airblader > From what I can tell, these violations are correct but do not seem to be identified when run through Maven. For example, `KafkaShuffleITCase` has its mini cluster defined in `KafkaTestBaseWithFlink` as `@ClassRule` + public + static, but not final, which indeed is a violation. That is right, I have the same issue and have tried all options I know. It looks like the import logic works differently while using maven and running it via intellij Idea. To fix it require much more time to dig into ArchUnit internal functionality. So, as trade-off, I chose the make maven work and create a follow-up PR to fix all the violations that will only found by intellij. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
