JingGe commented on pull request #18333:
URL: https://github.com/apache/flink/pull/18333#issuecomment-1012216057
> I think we're already not going for perfection. :-) My biggest pain point
is the fact that the test executes just fine, but produces a different
("incorrect") result. If the test failed to execute altogether from IntelliJ,
that'd be much better (but still quite sad). People wouldn't realize that and
enter some fight of fixing locally versus fixing the CI, and get very
frustrated in the process.
I have to respectively disagree :-). It is NOT incorrect, it just works in a
limited scope and within this scope it works correctly. And one thing should be
pointed out is that even the current ArchUnit tests are only cover part of the
whole Flink project, i.e. it has been running in a limited scope too. I knew
the difference is about the scope i.e. ImportOption and it is a good question
why ArchUnit works differently on maven and on IntelliJ with the same
ImportOption?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
