Airblader commented on pull request #18333: URL: https://github.com/apache/flink/pull/18333#issuecomment-1012222316
> It is NOT incorrect I think we have a misunderstanding here :-) What I mean is this: the results between IntelliJ and Maven are different = inconsistent. Since the CI is generally the source of truth, that means what a Maven run produces is "correct", making what IntelliJ produces "incorrect". Of course technically it seems like IntelliJ actually finds more correct violations, so the IntelliJ result is "more correct", but IntelliJ is not our source of truth. > it is a good question why ArchUnit works differently on maven and on IntelliJ with the same ImportOption? The problem here are the test-jars and how they're handled; we currently don't have an issue because we do not use JARs for the dependencies in the module. When IntelliJ executes the tests, it handles the dependencies differently than Maven, and that is causing the inconsistency. We can fix this by improving the import options to cover both scenarios equally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
