XComp commented on a change in pull request #18189:
URL: https://github.com/apache/flink/pull/18189#discussion_r787470497
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/JobResultEntry.java
##########
@@ -22,41 +22,18 @@
import org.apache.flink.util.Preconditions;
/**
- * An entry in a {@link JobResultStore} that couples a completed {@link
JobResult} to a state that
- * represents whether the resources of that JobResult have been finalized
({@link
- * JobResultState#CLEAN}) or have yet to be finalized ({@link
JobResultState#DIRTY}).
+ * {@code JobResultEntry} is the entity managed by the {@link JobResultStore}.
It collects
+ * information about a globally terminated job (e.g. {@link JobResult}).
*/
-public class JobResultEntry {
+public class JobResultEntry implements WithJobResult {
Review comment:
Initially, I though that it would be helpful for the file-based
implementation (where we want to add the serializer version to persisted
record). But looks like inheritance is good enough in that case. The interface
is of no value. I'm going to delete this commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
