Myasuka commented on a change in pull request #18514:
URL: https://github.com/apache/flink/pull/18514#discussion_r792481073
##########
File path:
flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/ChangelogKeyedStateBackend.java
##########
@@ -526,18 +510,16 @@ public void notifyCheckpointAborted(long checkpointId)
throws Exception {
}
Long materializationID =
materializationIdByCheckpointId.remove(checkpointId);
if (materializationID != null) {
- Set<Long> checkpoints =
pendingMaterializationConfirmations.get(materializationID);
- checkpoints.remove(checkpointId);
- if (checkpoints.isEmpty()) {
Review comment:
I think the newly added `lastCandidateAbortedMaterializationId` could
prevent this and would not notify abortion in (3) and then notify completion in
(4).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
