rkhachatryan commented on a change in pull request #18514:
URL: https://github.com/apache/flink/pull/18514#discussion_r792516364
##########
File path:
flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/ChangelogKeyedStateBackend.java
##########
@@ -526,18 +510,16 @@ public void notifyCheckpointAborted(long checkpointId)
throws Exception {
}
Long materializationID =
materializationIdByCheckpointId.remove(checkpointId);
if (materializationID != null) {
- Set<Long> checkpoints =
pendingMaterializationConfirmations.get(materializationID);
- checkpoints.remove(checkpointId);
- if (checkpoints.isEmpty()) {
Review comment:
How about this case:
1. materialization `M1` completes
1. checkpoint 1 using `M1` is started and aborted -
`lastCandidateAbortedMaterializationId` is set to `1`
1. materialization `M2` completes
1. checkpoint `2` using `M2` is started and aborted -
`lastCandidateAbortedMaterializationId` is set to `2`, nested backend notified
of **abortion** of `2`
1. checkpoint `3` using `M2` is started and completed -
`lastConfirmedMaterializationId` is set to `3`, nested backend notified of
**completion** of `2`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
