XComp commented on a change in pull request #18536:
URL: https://github.com/apache/flink/pull/18536#discussion_r796528547
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/highavailability/AbstractHaServicesTest.java
##########
@@ -185,15 +185,15 @@ public boolean get(JobID jobId, BlobKey blobKey, File
localFile) throws IOExcept
private final Queue<? super CloseOperations> closeOperations;
private final RunnableWithException internalCleanupRunnable;
- private final Consumer<JobID> internalJobCleanupConsumer;
+ private final ThrowingConsumer<JobID, Exception>
internalJobCleanupConsumer;
Review comment:
I would leave the `internalJobCleanup` method signature like it is. The
implementing classes don't use `IOException`, either. Changing the method
signature to use `IOException` would mean that we have to do the `IOException`
handling in each of the implementations. Instead, we can implement a general
`IOException` handling in `AbstractHaServices.globalCleanup()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
