XComp commented on a change in pull request #18536:
URL: https://github.com/apache/flink/pull/18536#discussion_r796428045
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/JobManagerMetricGroup.java
##########
@@ -33,7 +35,8 @@
* <p>Contains extra logic for adding jobs with tasks, and removing jobs when
they do not contain
* tasks any more
*/
-public class JobManagerMetricGroup extends
ComponentMetricGroup<JobManagerMetricGroup> {
+public class JobManagerMetricGroup extends
ComponentMetricGroup<JobManagerMetricGroup>
+ implements LocallyCleanableResource, GloballyCleanableResource {
Review comment:
Agree as already stated in [the comment
below](https://github.com/apache/flink/pull/18536#discussion_r796427461). I
will make change that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
