dannycranmer commented on a change in pull request #18733:
URL: https://github.com/apache/flink/pull/18733#discussion_r805832727
##########
File path:
flink-connectors/flink-connector-aws-base/src/main/java/org/apache/flink/connector/aws/util/AWSGeneralUtil.java
##########
@@ -273,7 +274,15 @@ public static SdkAsyncHttpClient createAsyncHttpClient(
public static SdkAsyncHttpClient createAsyncHttpClient(
final AttributeMap config, final NettyNioAsyncHttpClient.Builder
httpClientBuilder) {
+ return createAsyncHttpClient(config, httpClientBuilder,
SdkEventLoopGroup.builder());
Review comment:
Please confirm that defaults are actually used here. I followed the code
through and arrived here, when using a DefaultBuilder without setting any
values. Seems to default to 0 threads:
-
https://github.com/aws/aws-sdk-java-v2/blob/52a737b464d6d91247f1c53cfc994eeaeb375b5f/http-clients/netty-nio-client/src/main/java/software/amazon/awssdk/http/nio/netty/SdkEventLoopGroup.java#L127
##########
File path:
flink-connectors/flink-connector-aws-base/src/main/java/org/apache/flink/connector/aws/util/AWSGeneralUtil.java
##########
@@ -273,7 +274,15 @@ public static SdkAsyncHttpClient createAsyncHttpClient(
public static SdkAsyncHttpClient createAsyncHttpClient(
final AttributeMap config, final NettyNioAsyncHttpClient.Builder
httpClientBuilder) {
+ return createAsyncHttpClient(config, httpClientBuilder,
SdkEventLoopGroup.builder());
Review comment:
Please confirm which defaults are actually used here. I followed the
code through and arrived here, when using a DefaultBuilder without setting any
values. Seems to default to 0 threads:
-
https://github.com/aws/aws-sdk-java-v2/blob/52a737b464d6d91247f1c53cfc994eeaeb375b5f/http-clients/netty-nio-client/src/main/java/software/amazon/awssdk/http/nio/netty/SdkEventLoopGroup.java#L127
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
