CrynetLogistics commented on a change in pull request #18733:
URL: https://github.com/apache/flink/pull/18733#discussion_r805842675
##########
File path:
flink-connectors/flink-connector-aws-base/src/main/java/org/apache/flink/connector/aws/util/AWSGeneralUtil.java
##########
@@ -273,7 +274,15 @@ public static SdkAsyncHttpClient createAsyncHttpClient(
public static SdkAsyncHttpClient createAsyncHttpClient(
final AttributeMap config, final NettyNioAsyncHttpClient.Builder
httpClientBuilder) {
+ return createAsyncHttpClient(config, httpClientBuilder,
SdkEventLoopGroup.builder());
Review comment:
Hey, thank you for asking.
So it defaults to 0 threads and calls:
https://github.com/aws/aws-sdk-java-v2/blob/52a737b464d6d91247f1c53cfc994eeaeb375b5f/http-clients/netty-nio-client/src/main/java/software/amazon/awssdk/http/nio/netty/SdkEventLoopGroup.java#L132
From here, you can see it calls `super` with 0 threads too:
https://github.com/netty/netty/blob/4.1/transport/src/main/java/io/netty/channel/nio/NioEventLoopGroup.java
Finally in `MultithreadEventLoopGroup`, we have:
https://github.com/netty/netty/blob/d1a8cd2dec422f3b8fbfd186ae1ec29e680ffd4e/transport/src/main/java/io/netty/channel/MultithreadEventLoopGroup.java#L59
Which checks if threads=0 and if so uses the following formula:
https://github.com/netty/netty/blob/d1a8cd2dec422f3b8fbfd186ae1ec29e680ffd4e/transport/src/main/java/io/netty/channel/MultithreadEventLoopGroup.java#L40
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
