XComp commented on a change in pull request #18749:
URL: https://github.com/apache/flink/pull/18749#discussion_r805898045
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/JobManagerMetricGroup.java
##########
@@ -38,7 +39,7 @@
* tasks any more
*/
public class JobManagerMetricGroup extends
ComponentMetricGroup<JobManagerMetricGroup>
- implements LocallyCleanableResource {
+ implements LocallyCleanableResource, GloballyCleanableResource {
Review comment:
My intention to add the `GloballyCleanableResource` interface to the
`JobManagerMetricGroup` is based on the fact that the previous implementation
(i.e. 1.14-) cleaned the `JobManagerMetricGroup` in both cases, the local
cleanup and the global cleanup. I wanted to keep it like that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
