XComp commented on a change in pull request #18749:
URL: https://github.com/apache/flink/pull/18749#discussion_r805914906
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/cleanup/DispatcherResourceCleanerFactoryTest.java
##########
@@ -192,7 +192,6 @@ private void assertLocalCleanupNotTriggered() {
assertThat(jobManagerRunnerRegistryLocalCleanupFuture).isNotDone();
assertThat(jobGraphWriterLocalCleanupFuture).isNotDone();
assertThat(blobServer.getLocalCleanupFuture()).isNotDone();
-
assertThat(jobManagerMetricGroup.numRegisteredJobMetricGroups()).isEqualTo(1);
Review comment:
We had this discussion previously. We decided to not model a dependency
between the local and the global cleanup into the cleanable resources. That's
knowledge that's held by the Dispatcher how he (?) manages cleanups.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
