XComp opened a new pull request #18749:
URL: https://github.com/apache/flink/pull/18749
## What is the purpose of the change
I missed adding the `GloballyCleanableResource` to `JobManagerMetricGroup`
and adding it to the `DispatcherResourceCleanerFactory` under global cleanup
resources. This would cause the `JobManagerMetricGroup` not being cleaned up
after a global cleanup.
## Brief change log
* Makes `JobManagerMetricGroup` implement `GloballyCleanableResource`
* Adds `JobManagerMetricGroup` to `DispatcherResourceCleanerFactory`'s
`ResourceCleaner` instantiation for global cleanup
## Verifying this change
* The corresponding tests `DispatcherResourceCleanerFactory` and
`JobManagerGroupTest` were extended to cover the functionality
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: yes
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
