LadyForest commented on a change in pull request #23:
URL: https://github.com/apache/flink-table-store/pull/23#discussion_r811542477
##########
File path:
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/FileStoreOptions.java
##########
@@ -20,33 +20,105 @@
import org.apache.flink.configuration.ConfigOption;
import org.apache.flink.configuration.ConfigOptions;
+import org.apache.flink.configuration.Configuration;
import org.apache.flink.configuration.MemorySize;
-import org.apache.flink.configuration.ReadableConfig;
+import org.apache.flink.core.fs.Path;
+import org.apache.flink.table.store.file.mergetree.MergeTreeOptions;
+
+import java.io.Serializable;
+import java.time.Duration;
+
+import static org.apache.flink.configuration.ConfigOptions.key;
/** Options for {@link FileStore}. */
-public class FileStoreOptions {
+public class FileStoreOptions implements Serializable {
public static final ConfigOption<Integer> BUCKET =
ConfigOptions.key("bucket")
.intType()
.defaultValue(1)
.withDescription("Bucket number for file store.");
+ public static final ConfigOption<String> FILE_PATH =
+
ConfigOptions.key("file.path").stringType().noDefaultValue().withDescription("");
+
+ public static final ConfigOption<String> FILE_FORMAT =
+
ConfigOptions.key("file.format").stringType().defaultValue("orc").withDescription("");
+
+ public static final ConfigOption<String> MANIFEST_FORMAT =
+ ConfigOptions.key("manifest.format")
+ .stringType()
+ .defaultValue("avro")
+ .withDescription("");
Review comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
