LadyForest commented on a change in pull request #23:
URL: https://github.com/apache/flink-table-store/pull/23#discussion_r811549695
##########
File path:
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/operation/FileStoreScanImpl.java
##########
@@ -54,12 +55,13 @@
private final ManifestFile.Factory manifestFileFactory;
private final ManifestList manifestList;
- private Long snapshotId;
- private List<ManifestFileMeta> manifests;
private Predicate partitionFilter;
private Predicate keyFilter;
private Predicate valueFilter;
- private Integer bucket;
+
+ private Long specificSnapshotId = null;
Review comment:
Nit: towards naming, personally, I prefer `specifiedSnapshotId` over
`specificSanpshotId` cause **specified** sounds like somebody/the caller is
specifying this value from outside (which is more suitable, I think) while
`specific` sounds like the param is special.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
