yangjunhan commented on pull request #18868: URL: https://github.com/apache/flink/pull/18868#issuecomment-1047629822
Oh, thanks for the feedbacks @Airblader. I did some changes to the origin PR, mainly removing the abstractions that I was actually overthinking. What I am trying to do here is to make our modules and services more configurable. My first thought was to do an abstraction layer for each APIService and allows others to reuse those in their apps. However, after reconsidering it, it makes more sense to directly extend the services and override api methods for customization. So I guess the abstraction is meaningless in this sense. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
