yangjunhan commented on pull request #18868: URL: https://github.com/apache/flink/pull/18868#issuecomment-1047659718
> Thanks for the explanation. For what it's worth, with TypeScript's structural typing approach you don't _need_ dedicated base classes anyway since every class defines both a class and a type (of course depending on the situation, a dedicated type would still be cleaner). @Airblader You are definitely right! Thanks again for the advice. After this change being done, I plan to move on refactoring the components, making them depend on an injected config object and then we can config our component (view layer) through this config object! However, we cannot make everything configurable, I guess I will list them in a prioritized way and do it accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
