yangjunhan commented on a change in pull request #18868:
URL: https://github.com/apache/flink/pull/18868#discussion_r811783396
##########
File path: flink-runtime-web/web-dashboard/src/app/pages/job/job.component.ts
##########
@@ -49,6 +52,9 @@ export class JobComponent implements OnInit, OnDestroy {
takeUntil(this.destroy$),
mergeMap(() =>
this.jobService.loadJob(this.activatedRoute.snapshot.params.jid).pipe(
+ tap(job => {
+ this.jobLocalService.setJobDetail(job);
+ }),
Review comment:
This line of code was actually written in the API method's pipe. I moved
it here in order to decouple it from the api service to a service which is only
responsible for job's state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
