igalshilman commented on a change in pull request #304:
URL: https://github.com/apache/flink-statefun/pull/304#discussion_r814915931
##########
File path: statefun-sdk-go/v3/pkg/statefun/handler.go
##########
@@ -225,11 +225,10 @@ func (h *handler) invoke(ctx context.Context, toFunction
*protocol.ToFunction) (
var cancel context.CancelFunc
sContext.Context, cancel = context.WithCancel(ctx)
- var caller Address
if invocation.Caller != nil {
Review comment:
Can you please double check that this condition is enough?
as far as I know in Protobuf there are never nil fields, a missing field
would always be deserialized to an empty default value.
You can check the JavaSDk where we consider an empty Address to be missing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
