galenwarren commented on a change in pull request #304: URL: https://github.com/apache/flink-statefun/pull/304#discussion_r815047718
########## File path: statefun-sdk-go/v3/pkg/statefun/handler.go ########## @@ -225,11 +225,10 @@ func (h *handler) invoke(ctx context.Context, toFunction *protocol.ToFunction) ( var cancel context.CancelFunc sContext.Context, cancel = context.WithCancel(ctx) - var caller Address if invocation.Caller != nil { Review comment: Thanks! I appreciate your taking the time to do the review. Fwiw, I think you'll also see methods in Java-generated protobuf code that would allow you to determine if fields are set, but only for fields that correspond to messages. For example, here's one from my project: ``` /** * <code>.google.protobuf.Timestamp updated_at = 3;</code> * @return Whether the updatedAt field is set. */ @java.lang.Override public boolean hasUpdatedAt() { return updatedAt_ != null; } ``` ... which is generated for a message declared as follows: ``` message SomeMessage { google.protobuf.Timestamp updated_at = 3; } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org