igalshilman commented on a change in pull request #304:
URL: https://github.com/apache/flink-statefun/pull/304#discussion_r815035076
##########
File path: statefun-sdk-go/v3/pkg/statefun/handler.go
##########
@@ -225,11 +225,10 @@ func (h *handler) invoke(ctx context.Context, toFunction
*protocol.ToFunction) (
var cancel context.CancelFunc
sContext.Context, cancel = context.WithCancel(ctx)
- var caller Address
if invocation.Caller != nil {
Review comment:
The test indeed demonstrates that it works, I was a bit surprised
initially because with `Protobuf` 3 it should be impossible to differentiate
between a missing field or a field that is set to default values (even an
embedded one).
But your explanation, with a pointer being defaulted to `nil` makes sense! 👍
So let's go with that :-) !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
