[
https://issues.apache.org/jira/browse/FLINK-4173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15424263#comment-15424263
]
ASF GitHub Bot commented on FLINK-4173:
---------------------------------------
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2216
It would work but is more work for the user and is less prone to version
mismatches. Not using a fat-jar means that the users have to provide the
dependencies and put them in the `/libs` folder themselves. For ganglia for
example this would mean copying 5 jars. And there is no guarantee that the
version against which the reporter was compiled is identical to the one
provided at runtime.
> Replace maven-assembly-plugin by maven-shade-plugin in flink-metrics
> --------------------------------------------------------------------
>
> Key: FLINK-4173
> URL: https://issues.apache.org/jira/browse/FLINK-4173
> Project: Flink
> Issue Type: Bug
> Components: Metrics
> Affects Versions: 1.1.0
> Reporter: Till Rohrmann
> Assignee: Chesnay Schepler
> Priority: Minor
>
> The modules {{flink-metrics-dropwizard}}, {{flink-metrics-ganglia}} and
> {{flink-metrics-graphite}} use the {{maven-assembly-plugin}} to build a fat
> jar. The resulting fat jar has the suffix {{jar-with-dependencies}}. In order
> to make the naming consistent with the rest of the system we should create a
> fat-jar without this suffix.
> Additionally we could replace the {{maven-assembly-plugin}} with the
> {{maven-shade-plugin}} to make it consistent with the rest of the system.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
