JingGe commented on a change in pull request #18825:
URL: https://github.com/apache/flink/pull/18825#discussion_r817778468
##########
File path:
flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaWriterITCase.java
##########
@@ -147,13 +147,18 @@ public void testIncreasingRecordBasedCounters() throws
Exception {
try (final KafkaWriter<Integer> writer =
createWriterWithConfiguration(
getKafkaClientConfiguration(), DeliveryGuarantee.NONE,
metricGroup)) {
- final Counter numBytesOut =
operatorIOMetricGroup.getNumBytesOutCounter();
- final Counter numRecordsOut =
operatorIOMetricGroup.getNumRecordsOutCounter();
- assertEquals(numBytesOut.getCount(), 0L);
+ final Counter numBytesSend = metricGroup.getNumBytesSendCounter();
+ final Counter numRecordsSend =
metricGroup.getNumRecordsSendCounter();
+ final Counter numRecordsWrittenErrors =
metricGroup.getNumRecordsOutErrorsCounter();
+ assertEquals(numBytesSend.getCount(), 0L);
Review comment:
This is a JUnit 4 test. It make more sense to do the migration in the
separate thread. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
