JingGe commented on a change in pull request #18825:
URL: https://github.com/apache/flink/pull/18825#discussion_r819475475
##########
File path:
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaWriter.java
##########
@@ -406,6 +419,7 @@ public WriterCallback(
@Override
public void onCompletion(RecordMetadata metadata, Exception exception)
{
if (exception != null) {
+ numRecordsOutErrorsCounter.inc();
Review comment:
The metric is useful for user to be aware of the error even if it only
have 1. I will move the call to the mail box thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
