JingGe commented on a change in pull request #18825:
URL: https://github.com/apache/flink/pull/18825#discussion_r819574671
##########
File path:
flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaWriterITCase.java
##########
@@ -202,7 +233,10 @@ public void testMetadataPublisher() throws Exception {
expected.add("testMetadataPublisher-0@" + i);
}
writer.prepareCommit();
-
org.assertj.core.api.Assertions.assertThat(metadataList).isEqualTo(expected);
+ assertThat(metadataList)
+ .usingRecursiveComparison()
+ .ignoringCollectionOrder()
Review comment:
Using `contains` will require an additional check for the size. I think
you are right, it is not necessary to use this call, so removed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
