zentol commented on a change in pull request #19047:
URL: https://github.com/apache/flink/pull/19047#discussion_r824630269
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -1361,8 +1364,15 @@ public void onFatalError(Throwable exception) {
private class ShutDownFatalErrorHandler implements FatalErrorHandler {
+ private final Consumer<Throwable> customFatalErrorHandler;
+
+ public ShutDownFatalErrorHandler(Consumer<Throwable>
customFatalErrorHandler) {
+ this.customFatalErrorHandler = customFatalErrorHandler;
+ }
+
@Override
public void onFatalError(Throwable exception) {
+ customFatalErrorHandler.accept(exception);
Review comment:
since isn't really an error handler, for the simple reason that the
ShutDownFatalErrorHandler is still called and will still kill the mini cluster.
rephrase it to "fatalErrorListener".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
