zentol commented on a change in pull request #19047:
URL: https://github.com/apache/flink/pull/19047#discussion_r824644370
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/client/DuplicateJobSubmissionException.java
##########
@@ -35,10 +35,24 @@ public static DuplicateJobSubmissionException
ofGloballyTerminated(JobID jobId)
return new DuplicateJobSubmissionException(jobId, true);
}
+ public static DuplicateJobSubmissionException
ofGloballyTerminatedAndCleaned(JobID jobId) {
+ return new DuplicateJobSubmissionException(
+ jobId,
+ true,
+ "There's already a job with the given JobID '"
+ + jobId
+ + "' listed as globally-terminated and cleaned. No
further actions required.");
Review comment:
I'm not sure if this is sufficient.
It says "No further actions required", but I'm not sure whether this refers
to Flink ("I don't need to run anything") or the user ("I can ignore this
error").
Then, let's say a user really wants to run the job anyway; how do they
achieve that? (This is particularly important because ZERO_JOB_ID exists)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
