zentol commented on a change in pull request #19047:
URL: https://github.com/apache/flink/pull/19047#discussion_r824635446
##########
File path:
flink-clients/src/test/java/org/apache/flink/client/deployment/application/ApplicationDispatcherBootstrapTest.java
##########
@@ -265,6 +265,35 @@ public void testApplicationFailsAsSoonAsOneJobFails()
throws Throwable {
assertEquals(exception.getStatus(), ApplicationStatus.FAILED);
}
+ @Test
+ public void testApplicationFailsIfJobIsAlreadyMarkedAsClean() throws
Throwable {
+ final Configuration configuration = getConfiguration();
+ final JobID jobId = new JobID();
+ configuration.set(PipelineOptionsInternal.PIPELINE_FIXED_JOB_ID,
jobId.toHexString());
+
+ final ApplicationDispatcherBootstrap bootstrap =
+ new ApplicationDispatcherBootstrap(
+ getProgram(1),
+ Collections.emptyList(),
+ actualJobId -> true,
+ configuration,
+ // passing null should not lead to any problem because
we want to fail
+ // before doing any call to the dispatcher
+ null,
Review comment:
eh. Why should this test fail if I eagerly retrieve the address from the
dispatcher gateway?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
