zentol commented on a change in pull request #19039:
URL: https://github.com/apache/flink/pull/19039#discussion_r826152738
##########
File path:
flink-table/flink-table-runtime/src/test/java/org/apache/flink/table/runtime/operators/join/RandomSortMergeInnerJoinTest.java
##########
@@ -126,15 +126,11 @@ public void test() throws Exception {
match(expectedMatchesMap, transformToBinary(join(operator, input1,
input2)));
// assert that each expected match was seen
- for (Map.Entry<Integer, Collection<Match>> entry :
expectedMatchesMap.entrySet()) {
- assertThat(entry.getValue().isEmpty())
- .as("Collection for key " + entry.getKey() + " is not
empty")
- .isTrue();
- }
+ assertThat(expectedMatchesMap).allSatisfy((i, e) ->
assertThat(e).isNotEmpty());
Review comment:
now you inverted both and its again wrong :D
We were previously checking that all contained collections are empty. So
either allSatisfy(isEmpty) or nonSatisfy(isNotEmpty)
##########
File path:
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/utils/DiffRepository.java
##########
@@ -317,7 +317,7 @@ public synchronized String expand(String testCaseName,
String tag, String text)
* @param value Value of the resource
*/
public synchronized void set(String testCaseName, String resourceName,
String value) {
- assertThat(resourceName).isNotNull();
+ assert resourceName != null;
Review comment:
makes sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
