zentol commented on a change in pull request #19039:
URL: https://github.com/apache/flink/pull/19039#discussion_r826141790
##########
File path:
flink-table/flink-table-runtime/src/test/java/org/apache/flink/table/runtime/operators/join/RandomSortMergeInnerJoinTest.java
##########
@@ -126,15 +126,11 @@ public void test() throws Exception {
match(expectedMatchesMap, transformToBinary(join(operator, input1,
input2)));
// assert that each expected match was seen
- for (Map.Entry<Integer, Collection<Match>> entry :
expectedMatchesMap.entrySet()) {
- assertThat(entry.getValue().isEmpty())
- .as("Collection for key " + entry.getKey() + " is not
empty")
- .isTrue();
- }
+ assertThat(expectedMatchesMap).allSatisfy((i, e) ->
assertThat(e).isNotEmpty());
Review comment:
should assert isEmpty, or use noneSatisfy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
