slinkydeveloper commented on a change in pull request #19039:
URL: https://github.com/apache/flink/pull/19039#discussion_r826028761
##########
File path:
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/typeutils/RowTypeUtilsTest.java
##########
@@ -18,24 +18,25 @@
package org.apache.flink.table.planner.typeutils;
-import org.junit.Assert;
import org.junit.Test;
import java.util.Arrays;
+import static org.assertj.core.api.Assertions.assertThat;
+
/** Tests for {@link RowTypeUtils}. */
public class RowTypeUtilsTest {
@Test
public void testGetUniqueName() {
- Assert.assertEquals(
- Arrays.asList("Dave", "Evan"),
- RowTypeUtils.getUniqueName(
- Arrays.asList("Dave", "Evan"), Arrays.asList("Alice",
"Bob")));
- Assert.assertEquals(
- Arrays.asList("Bob_0", "Bob_1", "Dave", "Alice_0"),
- RowTypeUtils.getUniqueName(
- Arrays.asList("Bob", "Bob", "Dave", "Alice"),
- Arrays.asList("Alice", "Bob")));
+ assertThat(
+ RowTypeUtils.getUniqueName(
+ Arrays.asList("Dave", "Evan"),
Arrays.asList("Alice", "Bob")))
+ .isEqualTo(Arrays.asList("Dave", "Evan"));
Review comment:
In this case seems like the order matters
##########
File path:
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/typeutils/RowTypeUtilsTest.java
##########
@@ -18,24 +18,25 @@
package org.apache.flink.table.planner.typeutils;
-import org.junit.Assert;
import org.junit.Test;
import java.util.Arrays;
+import static org.assertj.core.api.Assertions.assertThat;
+
/** Tests for {@link RowTypeUtils}. */
public class RowTypeUtilsTest {
@Test
public void testGetUniqueName() {
- Assert.assertEquals(
- Arrays.asList("Dave", "Evan"),
- RowTypeUtils.getUniqueName(
- Arrays.asList("Dave", "Evan"), Arrays.asList("Alice",
"Bob")));
- Assert.assertEquals(
- Arrays.asList("Bob_0", "Bob_1", "Dave", "Alice_0"),
- RowTypeUtils.getUniqueName(
- Arrays.asList("Bob", "Bob", "Dave", "Alice"),
- Arrays.asList("Alice", "Bob")));
+ assertThat(
+ RowTypeUtils.getUniqueName(
+ Arrays.asList("Dave", "Evan"),
Arrays.asList("Alice", "Bob")))
+ .isEqualTo(Arrays.asList("Dave", "Evan"));
Review comment:
In this case seems like the order matters, so equal to is fine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
