JingsongLi commented on a change in pull request #56:
URL: https://github.com/apache/flink-table-store/pull/56#discussion_r833163883
##########
File path:
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/FileStoreOptions.java
##########
@@ -94,7 +94,7 @@
public static final ConfigOption<Duration> SNAPSHOT_TIME_RETAINED =
ConfigOptions.key("snapshot.time-retained")
.durationType()
- .defaultValue(Duration.ofDays(1))
+ .defaultValue(Duration.ofHours(1))
Review comment:
We do not expose the middle snapshot out, every read is read the latest,
there is no need to keep it for such a long time.
Keeping it too long will result in a lot of small files remaining on the DFS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]