JingsongLi commented on a change in pull request #56:
URL: https://github.com/apache/flink-table-store/pull/56#discussion_r833193201
##########
File path:
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/operation/FileStoreExpireImpl.java
##########
@@ -91,7 +110,7 @@ public void expire() {
<= millisRetained) {
// within time threshold, can assume that all snapshots
after it are also within
// the threshold
- expireUntil(id);
+ expireUntil(earliest, id);
Review comment:
For above handle for "No expire happens", leave in `expireUntil`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
