tsreaper commented on a change in pull request #56:
URL: https://github.com/apache/flink-table-store/pull/56#discussion_r834058615
##########
File path:
flink-table-store-core/src/test/java/org/apache/flink/table/store/file/TestFileStore.java
##########
@@ -314,6 +315,12 @@ public void assertCleaned() {
} catch (IOException e) {
throw new RuntimeException(e);
}
+
+ // remove best effort latest and earliest hint files
+ Path snapshotDir = pathFactory().snapshotDirectory();
+ actualFiles.remove(new Path(snapshotDir, SnapshotFinder.LATEST));
+ actualFiles.remove(new Path(snapshotDir, SnapshotFinder.EARLIEST));
Review comment:
No, latest must be equal to the ground truth. It is only changed by the
commit operation and that value should be precise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
