matriv commented on code in PR #19302:
URL: https://github.com/apache/flink/pull/19302#discussion_r842691799
##########
flink-connectors/flink-connector-elasticsearch-base/src/test/java/org/apache/flink/connector/elasticsearch/table/IndexGeneratorTest.java:
##########
@@ -101,9 +105,28 @@
LocalDateTime.of(2020, 3, 19, 12, 22, 14,
1000)),
(int) LocalDate.of(2020, 3, 19).toEpochDay(),
(int) (LocalTime.of(12, 13, 14,
2000).toNanoOfDay() / 1_000_000L),
+
TimestampData.fromTimestamp(Timestamp.valueOf("2020-03-19 12:22:14")),
"test2",
false));
+ @Test
+ public void testDynamicIndexFromTimestampTz() {
+ IndexGenerator indexGenerator =
+ IndexGeneratorFactory.createIndexGenerator(
Review Comment:
Also here you're using the
```createIndexGenerator(String index, List<String> fieldNames,
List<DataType> dataTypes) ```
instead of
```
public static IndexGenerator createIndexGenerator(
String index,
List<String> fieldNames,
List<DataType> dataTypes,
ZoneId localTimeZoneId) {
```
were you can pass a custom zone, or also the UTC and be independent of the
CI's system default for example.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
