matriv commented on code in PR #19302:
URL: https://github.com/apache/flink/pull/19302#discussion_r842737609
##########
flink-connectors/flink-connector-elasticsearch-base/src/test/java/org/apache/flink/connector/elasticsearch/table/IndexGeneratorTest.java:
##########
@@ -101,9 +110,44 @@
LocalDateTime.of(2020, 3, 19, 12, 22, 14,
1000)),
(int) LocalDate.of(2020, 3, 19).toEpochDay(),
(int) (LocalTime.of(12, 13, 14,
2000).toNanoOfDay() / 1_000_000L),
+ TimestampData.fromInstant(
+ LocalDateTime.of(2020, 3, 19, 12, 22, 14,
1000)
+ .atZone(ZoneId.of("Asia/Shanghai"))
Review Comment:
nit: I would use another timezone here, maybe `America/Los_Angeles` which
has a `-` offset from UTC.
Maybe also use an hour > 12 closer to 24, like `20` to have a resulting date
that "jumps ahead" (20/3 instead of 19/3).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
