matriv commented on code in PR #19302:
URL: https://github.com/apache/flink/pull/19302#discussion_r842760371
##########
flink-connectors/flink-connector-elasticsearch-base/src/test/java/org/apache/flink/connector/elasticsearch/table/IndexGeneratorTest.java:
##########
@@ -101,9 +110,44 @@
LocalDateTime.of(2020, 3, 19, 12, 22, 14,
1000)),
(int) LocalDate.of(2020, 3, 19).toEpochDay(),
(int) (LocalTime.of(12, 13, 14,
2000).toNanoOfDay() / 1_000_000L),
+ TimestampData.fromInstant(
+ LocalDateTime.of(2020, 3, 19, 20, 22, 14,
1000)
+
.atZone(ZoneId.of("America/Los_Angeles"))
+ .toInstant()),
"test2",
false));
+ @Test
+ public void testDynamicIndexFromTimestampTzUTC() {
+ assumingThat(
+ ZoneId.systemDefault().equals(ZoneId.of("UTC")),
+ () -> {
+ IndexGenerator indexGenerator =
+ IndexGeneratorFactory.createIndexGenerator(
+ "{local_timestamp|yyyy_MM_dd_HH-ss}_index",
+ fieldNames,
+ dataTypes);
+ indexGenerator.open();
+ Assertions.assertEquals(
+ "2020_03_17_19-14_index",
indexGenerator.generate(rows.get(0)));
+ Assertions.assertEquals(
+ "2020_03_20_03-14_index",
indexGenerator.generate(rows.get(1)));
+ });
+ }
+
+ @Test
+ public void testDynamicIndexFromTimestampTzWithSpecificTimezone() {
+ IndexGenerator indexGenerator =
+ IndexGeneratorFactory.createIndexGenerator(
+ "{local_timestamp|yyyy_MM_dd_HH-ss}_index",
+ fieldNames,
+ dataTypes,
+ ZoneId.of("UTC"));
Review Comment:
Sorry, last comment, here you can use yet another zone, like: "Europe/Berlin"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
