zentol commented on code in PR #19351:
URL: https://github.com/apache/flink/pull/19351#discussion_r842959149
##########
flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/slot/TaskSlotUtils.java:
##########
@@ -71,11 +77,8 @@ public static ResourceProfile createTotalResourceProfile(int
numberOfSlots) {
return result;
}
- public static TimerService<AllocationID> createDefaultTimerService() {
- return createDefaultTimerService(DEFAULT_SLOT_TIMEOUT);
- }
-
public static TimerService<AllocationID> createDefaultTimerService(long
shutdownTimeout) {
- return new DefaultTimerService<>(TestingUtils.defaultExecutor(),
shutdownTimeout);
+ return new DefaultTimerService<>(
+ Executors.newSingleThreadScheduledExecutor(), shutdownTimeout);
Review Comment:
Not required in this case (and actually harmful) because the timer service
expects to own the executor and is shutting it down.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
