zentol commented on code in PR #19351:
URL: https://github.com/apache/flink/pull/19351#discussion_r843010096
##########
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/TestingDefaultExecutionGraphBuilder.java:
##########
@@ -56,12 +57,23 @@
private static final Logger LOG =
LoggerFactory.getLogger(TestingDefaultExecutionGraphBuilder.class);
+ private static final ScheduledExecutorService FUTURE_EXECUTOR =
+ Executors.newScheduledThreadPool(
+ 0,
+ new ExecutorThreadFactory(
+ "flink-future-" +
TestingDefaultExecutionGraphBuilder.class));
+
+ private static final Executor IO_EXECUTOR =
+ Executors.newCachedThreadPool(
+ new ExecutorThreadFactory(
+ "flink-io-" +
TestingDefaultExecutionGraphBuilder.class));
Review Comment:
My thinking was that in this case the executors aren't doing anything
interesting, and since they are static we aren't leaking threads, Ultimately I
just wanted to reduce the number of tests I had to touch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
