zentol commented on code in PR #19351:
URL: https://github.com/apache/flink/pull/19351#discussion_r842964196
##########
flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/slotmanager/DeclarativeSlotManagerBuilder.java:
##########
@@ -66,13 +66,8 @@ private DeclarativeSlotManagerBuilder() {
this.slotTracker = new DefaultSlotTracker();
}
- public static DeclarativeSlotManagerBuilder newBuilder() {
- return new DeclarativeSlotManagerBuilder();
- }
-
- public DeclarativeSlotManagerBuilder
setScheduledExecutor(ScheduledExecutor scheduledExecutor) {
- this.scheduledExecutor = scheduledExecutor;
- return this;
+ public static DeclarativeSlotManagerBuilder newBuilder(ScheduledExecutor
scheduledExecutor) {
Review Comment:
I generally agree and a bit inconsistent in this regard. There are some
cases where passing it via the constructor required less refactorings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
