zentol commented on code in PR #19351:
URL: https://github.com/apache/flink/pull/19351#discussion_r844067543
##########
flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/TestingJobManagerSharedServicesBuilder.java:
##########
@@ -76,7 +59,10 @@ public void setBlobWriter(BlobWriter blobWriter) {
}
public JobManagerSharedServices build() {
+ final ScheduledExecutorService executorService =
+ Executors.newSingleThreadScheduledExecutor();
Review Comment:
I will fix those tests.
##########
flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/utils/JobMasterBuilder.java:
##########
@@ -188,7 +187,9 @@ public JobMaster createJobMaster() throws Exception {
? slotPoolServiceSchedulerFactory
:
DefaultSlotPoolServiceSchedulerFactory.fromConfiguration(
configuration, jobGraph.getJobType()),
- jobManagerSharedServices,
+ jobManagerSharedServices != null
+ ? jobManagerSharedServices
+ : new TestingJobManagerSharedServicesBuilder().build(),
Review Comment:
yes; and see above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
