zentol commented on code in PR #19351:
URL: https://github.com/apache/flink/pull/19351#discussion_r844069571
##########
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskTest.java:
##########
@@ -132,19 +139,28 @@ public void teardown() throws Exception {
@Test
public void testCleanupWhenRestoreFails() throws Exception {
-
createTaskBuilder().setInvokable(InvokableWithExceptionInRestore.class).build().run();
+ createTaskBuilder()
+ .setInvokable(InvokableWithExceptionInRestore.class)
+ .build(Executors.directExecutor())
Review Comment:
I'd rather not because we shouldn't _really_ encourage the use of direct
executors. If used incorrectly (which we generally do) then the test no longer
works under the same conditions as in production because the threading behavior
is radically different.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
