XComp commented on code in PR #19351:
URL: https://github.com/apache/flink/pull/19351#discussion_r844016207
##########
flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskManagerServicesBuilder.java:
##########
@@ -180,7 +172,7 @@ public TaskManagerServices build() {
taskStateManager,
taskChangelogStoragesManager,
taskEventDispatcher,
- ioExecutor,
+ Executors.newSingleThreadScheduledExecutor(),
Review Comment:
`MetricUtilsTest.testManagedMemoryMetricsInitialization` instantiates
`TaskManagerServices` but never calls shutdown on that instance. Additionally,
`TaskSubmissionTestEnvironment` does not expose shutdown logic (as far as I can
see). All the other tests calling instantiating `TaskManagerServices` seem to
have the `TaskExecutor` being instantiated and call close or stop on that one
(i.e. these tests should be fine).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
