rkhachatryan commented on code in PR #19331:
URL: https://github.com/apache/flink/pull/19331#discussion_r841065426
##########
flink-tests/src/test/java/org/apache/flink/test/checkpointing/ResumeCheckpointManuallyITCase.java:
##########
@@ -269,17 +317,19 @@ private void testExternalizedCheckpoints(
try {
// main test sequence: start job -> eCP -> restore job -> eCP ->
restore job
String firstExternalCheckpoint =
- runJobAndGetExternalizedCheckpoint(backend, checkpointDir,
null, client);
+ runJobAndGetExternalizedCheckpoint(
+ backend, checkpointDir, null, client, restoreMode);
assertNotNull(firstExternalCheckpoint);
String secondExternalCheckpoint =
runJobAndGetExternalizedCheckpoint(
- backend, checkpointDir, firstExternalCheckpoint,
client);
+ backend, checkpointDir, firstExternalCheckpoint,
client, restoreMode);
assertNotNull(secondExternalCheckpoint);
String thirdExternalCheckpoint =
runJobAndGetExternalizedCheckpoint(
- backend, checkpointDir, secondExternalCheckpoint,
client);
+ // restore from the 1st external checkpoint path
+ backend, checkpointDir, firstExternalCheckpoint,
client, restoreMode);
Review Comment:
You're right, I'll revert this change.
edit:
parameterized the test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
