rkhachatryan commented on code in PR #19331:
URL: https://github.com/apache/flink/pull/19331#discussion_r845987706
##########
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/cleanup/CheckpointResourcesCleanupRunner.java:
##########
@@ -118,7 +119,11 @@ public void start() throws Exception {
}
private void cleanupCheckpoints() throws Exception {
- final CompletedCheckpointStore completedCheckpointStore =
createCompletedCheckpointStore();
+ final CompletedCheckpointStore completedCheckpointStore =
+ // Using RestoreMode.CLAIM to be able to discard shared state,
if any
+ // Note that it also means that the original shared state
might be discarded as well
+ // because the initial checkpoint might be subsumed.
+ createCompletedCheckpointStore(RestoreMode.CLAIM);
Review Comment:
I agree, inlined the argument.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
